]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUILD: ssl: avoid possible printf format warning in traces
authorWilly Tarreau <w@1wt.eu>
Wed, 21 May 2025 08:01:14 +0000 (10:01 +0200)
committerWilly Tarreau <w@1wt.eu>
Wed, 21 May 2025 08:01:14 +0000 (10:01 +0200)
When building on MIPS-32 with gcc-9.5 and glibc-2.31, I got this:

  src/ssl_trace.c: In function 'ssl_trace':
  src/ssl_trace.c:118:42: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'ssize_t' {aka 'const int'} [-Wformat=]
    118 |     chunk_appendf(&trace_buf, " : size=%ld", *size);
        |                                        ~~^   ~~~~~
        |                                          |   |
        |                                          |   ssize_t {aka const int}
        |                                          long int
        |                                        %d

Let's just cast the type. No backport needed.

src/ssl_trace.c

index 8f77fb23cd83ea67132c95e7527196449d135aaa..ee65499cab3023929eb2a534f150ee33bfc8be1d 100644 (file)
@@ -115,7 +115,7 @@ static void ssl_trace(enum trace_level level, uint64_t mask, const struct trace_
                        const ssize_t *size = a2;
 
                        if (size)
-                               chunk_appendf(&trace_buf, " : size=%ld", *size);
+                               chunk_appendf(&trace_buf, " : size=%ld", (long)*size);
                }
        }