]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
lock: avoid leak on failure
authorEric Blake <eblake@redhat.com>
Thu, 2 Jun 2011 22:38:38 +0000 (16:38 -0600)
committerEric Blake <eblake@redhat.com>
Fri, 3 Jun 2011 14:11:43 +0000 (08:11 -0600)
Detected by Coverity.  Only possible on OOM situations.

* src/locking/lock_manager.c (virLockManagerPluginNew): Plug leak.

src/locking/lock_manager.c

index 6197fd404eb07d18215a64071e595a872c795384..138cc91997ed73a4002828aeae66131f8cdf3a2c 100644 (file)
@@ -120,7 +120,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name,
 {
     void *handle = NULL;
     virLockDriverPtr driver;
-    virLockManagerPluginPtr plugin;
+    virLockManagerPluginPtr plugin = NULL;
     const char *moddir = getenv("LIBVIRT_LOCK_MANAGER_PLUGIN_DIR");
     char *modfile = NULL;
 
@@ -182,6 +182,7 @@ virLockManagerPluginPtr virLockManagerPluginNew(const char *name,
     return plugin;
 
 cleanup:
+    VIR_FREE(plugin);
     VIR_FREE(modfile);
     if (handle)
         dlclose(handle);