]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
pinctrl: renesas: rzg2l: Update PIN_CFG_MASK() macro to be 32-bit wide
authorLad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Tue, 18 Jun 2024 17:48:28 +0000 (18:48 +0100)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 24 Jun 2024 13:56:30 +0000 (15:56 +0200)
Modify the `PIN_CFG_MASK()` macro to be 32-bit wide. The current maximum
value for `PIN_CFG_*` is `BIT(21)`, which fits within a 32-bit mask.

Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Link: https://lore.kernel.org/r/20240618174831.415583-2-prabhakar.mahadev-lad.rj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rzg2l.c

index 32945d4c8dc04dce75182d91f684d5390667c60c..bfaeeb00ac4a1f07c4a0ba8374101bff5deeb99f 100644 (file)
@@ -89,7 +89,7 @@
 
 #define PIN_CFG_PIN_MAP_MASK           GENMASK_ULL(62, 55)
 #define PIN_CFG_PIN_REG_MASK           GENMASK_ULL(54, 47)
-#define PIN_CFG_MASK                   GENMASK_ULL(46, 0)
+#define PIN_CFG_MASK                   GENMASK_ULL(31, 0)
 
 /*
  * m indicates the bitmap of supported pins, a is the register index
@@ -1187,7 +1187,7 @@ static int rzg2l_pinctrl_pinconf_get(struct pinctrl_dev *pctldev,
        u64 *pin_data = pin->drv_data;
        unsigned int arg = 0;
        u32 off;
-       u64 cfg;
+       u32 cfg;
        int ret;
        u8 bit;
 
@@ -1322,7 +1322,7 @@ static int rzg2l_pinctrl_pinconf_set(struct pinctrl_dev *pctldev,
        u64 *pin_data = pin->drv_data;
        unsigned int i, arg, index;
        u32 off, param;
-       u64 cfg;
+       u32 cfg;
        int ret;
        u8 bit;
 
@@ -2755,9 +2755,9 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen
 
        for (u32 port = 0; port < nports; port++) {
                bool has_iolh, has_ien;
-               u64 cfg, caps;
+               u32 off, caps;
                u8 pincnt;
-               u32 off;
+               u64 cfg;
 
                cfg = pctrl->data->port_pin_configs[port];
                off = RZG2L_PIN_CFG_TO_PORT_OFFSET(cfg);
@@ -2801,7 +2801,7 @@ static void rzg2l_pinctrl_pm_setup_regs(struct rzg2l_pinctrl *pctrl, bool suspen
 static void rzg2l_pinctrl_pm_setup_dedicated_regs(struct rzg2l_pinctrl *pctrl, bool suspend)
 {
        struct rzg2l_pinctrl_reg_cache *cache = pctrl->dedicated_cache;
-       u64 caps;
+       u32 caps;
        u32 i;
 
        /*