]> git.ipfire.org Git - thirdparty/git.git/commitdiff
midx.c: remove unnecessary loop condition
authorTaylor Blau <me@ttaylorr.com>
Tue, 20 Sep 2022 01:55:53 +0000 (21:55 -0400)
committerJunio C Hamano <gitster@pobox.com>
Wed, 21 Sep 2022 17:21:47 +0000 (10:21 -0700)
The fill_included_packs_batch() routine is responsible for aggregating
objects in packs with a non-zero value for the `--batch-size` option of
the `git multi-pack-index repack` sub-command.

Since this routine is explicitly called only when `--batch-size` is
non-zero, there is no point in checking that this is the case in our
loop condition.

Remove the unnecessary part of this condition to avoid confusion.

Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
midx.c

diff --git a/midx.c b/midx.c
index d703fc5a16f138665cebdf48ed045da1f10671cf..273704caedb7aacbdee531a1cbaff4d0ba3de3a5 100644 (file)
--- a/midx.c
+++ b/midx.c
@@ -1928,7 +1928,7 @@ static int fill_included_packs_batch(struct repository *r,
                pack_info[i].mtime = m->packs[i]->mtime;
        }
 
-       for (i = 0; batch_size && i < m->num_objects; i++) {
+       for (i = 0; i < m->num_objects; i++) {
                uint32_t pack_int_id = nth_midxed_pack_int_id(m, i);
                pack_info[pack_int_id].referenced_objects++;
        }