Optimization: esiChoose constructor call copied parent pointer (#1803)

Detected by Coverity. CID 1529569: Unnecessary object copies can affect
performance (COPY_INSTEAD_OF_MOVE).

diff --git a/src/esi/Esi.cc b/src/esi/Esi.cc
index c4e9194586c09bb4a5c47635b587fd5976e90e79..59339226cc6577b2fbb2bfe44661e087838177d0 100644 (file)
--- a/src/esi/Esi.cc
+++ b/src/esi/Esi.cc
@@ -163,7 +163,7 @@ class esiChoose : public ESIElement
     MEMPROXY_CLASS(esiChoose);
 
 public:
-    esiChoose(esiTreeParentPtr);
+    esiChoose(const esiTreeParentPtr &);
     ~esiChoose() override;
 
     void render(ESISegment::Pointer) override;
@@ -1889,7 +1889,7 @@ esiChoose::~esiChoose()
     FinishAllElements(elements); // finish if not already done
 }
 
-esiChoose::esiChoose(esiTreeParentPtr aParent) :
+esiChoose::esiChoose(const esiTreeParentPtr & aParent) :
     elements(),
     chosenelement(-1),
     parent(aParent)