]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Bug 2899: Restore lost rfc1738_unescape() data type
authorAmos Jeffries <squid3@treenet.co.nz>
Fri, 9 Apr 2010 00:39:54 +0000 (12:39 +1200)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 9 Apr 2010 00:39:54 +0000 (12:39 +1200)
Data type was converted to char from int during recent upgrades.
On unix systems char is unsigned making the safety checks fail on build.
This reverts the type back to a usable signed int, no logic changes.

lib/rfc1738.c

index 6158375686ce9807af87b5cbda44be247258e26a..70289b4545a53bd6237a06916051d88079271f6a 100644 (file)
@@ -174,8 +174,7 @@ rfc1738_unescape(char *s)
             j++;               /* Skip % */
         } else {
             /* decode */
-            char v1, v2;
-            int x;
+            int v1, v2, x;
             v1 = fromhex(s[j + 1]);
             if (v1 < 0)
                 continue;  /* non-hex or \0 */