]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_daemon.c: fix Coverity CID#32408 Missing unlock
authorMarek Schimara <Marek.Schimara@bull.net>
Wed, 15 Jun 2016 13:36:28 +0000 (15:36 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:33 +0000 (16:32 +0200)
        CWE-667 / https://cwe.mitre.org/data/definitions/667.html

src/rrd_daemon.c

index 99774abdc9e58b1652e73168258c0db412b9d038..9e3596ab0cc7ba55aff001db9e6491ae87c89522 100644 (file)
@@ -2277,10 +2277,12 @@ static int handle_request_create (HANDLER_PROTO) /* {{{ */
         rc = send_response(sock, RESP_ERR,
             "No permission to recursively create: %s\nDid you pass -R to the daemon?\n",
             dir);
+        pthread_mutex_unlock(&rrdfilecreate_lock);
         goto done;
     }
     if (rrd_mkdir_p(dir, 0755) != 0) {
         rc = send_response(sock, RESP_ERR, "Cannot create: %s\n", dir);
+        pthread_mutex_unlock(&rrdfilecreate_lock);
         goto done;
     }
   }