]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
CI: disable code coverage in GH Action
authorLuca Boccassi <luca.boccassi@microsoft.com>
Wed, 20 Oct 2021 21:10:56 +0000 (22:10 +0100)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 20 Oct 2021 23:10:52 +0000 (00:10 +0100)
It is now ran on the nightly CentOS build, so that it can cover
integration tests too, and not just unit tests. It's nightly as
it considerably increases the integration test runtime, so it's
not appropriate for all PRs.

.github/workflows/unit_tests.sh
.github/workflows/unit_tests.yml

index e1f7a4be1e5e402d237dbd9be59c182b893402ff..7e7e3016e8e0d9b45aa1dbfe340b89d4c7c67a2f 100755 (executable)
@@ -9,7 +9,6 @@ ADDITIONAL_DEPS=(
     expect
     fdisk
     jekyll
-    lcov
     libfdisk-dev
     libfido2-dev
     libp11-kit-dev
@@ -48,17 +47,9 @@ for phase in "${PHASES[@]}"; do
                 # The docs build is slow and is not affected by compiler/flags, so do it just once
                 MESON_ARGS+=(-Dman=true)
             fi
-            if [[ "$phase" = "RUN_GCC" ]]; then
-                MESON_ARGS+=(-Db_coverage=true)
-                # See FIXME below
-                (set +x; while :; do echo -ne "\n[WATCHDOG] $(date)\n"; sleep 30; done) &
-            fi
             meson --werror -Dtests=unsafe -Dslow-tests=true -Dfuzz-tests=true "${MESON_ARGS[@]}" build
             ninja -C build -v
             meson test -C build --print-errorlogs
-            if [[ "$phase" = "RUN_GCC" ]]; then
-                ninja -C build coverage
-            fi
             ;;
         RUN_ASAN_UBSAN|RUN_GCC_ASAN_UBSAN|RUN_CLANG_ASAN_UBSAN)
             MESON_ARGS=(--optimization=1)
index e697e6485d8defe00cc1c57bc7afdb76a3687b60..0b8c1782ea3e21545d52f0dccd64926424c7e485 100644 (file)
@@ -29,9 +29,3 @@ jobs:
       - name: Build & test (${{ matrix.run_phase }})
         run: sudo -E .github/workflows/unit_tests.sh RUN_${{ matrix.run_phase }}
         if: github.event_name == 'pull_request' || matrix.run_phase == 'GCC'
-      - name: Coveralls
-        if: matrix.run_phase == 'GCC' && github.repository == 'systemd/systemd'
-        uses: coverallsapp/github-action@master
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          path-to-lcov: ./build/meson-logs/coverage.info