]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value...
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 17 Feb 2025 14:16:12 +0000 (14:16 +0000)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 4 Mar 2025 13:17:49 +0000 (13:17 +0000)
The data used is all in local variables so there is no advantage
in setting *val = ret with the direct mode claim held.
Move it later to after error check.

Reviewed-by: Nuno Sá <nuno.sa@analog.com>
Link: https://patch.msgid.link/20250217141630.897334-13-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ad7768-1.c

index 113703fb724544a848b78b48e1e4d640355c2776..c2ba357b82d85869152d8cae427948a4e885d2cd 100644 (file)
@@ -370,12 +370,11 @@ static int ad7768_read_raw(struct iio_dev *indio_dev,
                        return ret;
 
                ret = ad7768_scan_direct(indio_dev);
-               if (ret >= 0)
-                       *val = ret;
 
                iio_device_release_direct_mode(indio_dev);
                if (ret < 0)
                        return ret;
+               *val = ret;
 
                return IIO_VAL_INT;