]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
serialtweaker: add comment on why empty SOA-EDIT is "wrong"
authorChris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Wed, 27 Jun 2018 13:21:12 +0000 (15:21 +0200)
committerChris Hofstaedtler <chris.hofstaedtler@deduktiva.com>
Wed, 27 Jun 2018 13:21:12 +0000 (15:21 +0200)
pdns/serialtweaker.cc

index 7b1d7c7b9f0032950872750fd86eecbac67a699f..bd04c344dfdb643f0b33a4e8b37a114085fddd10 100644 (file)
@@ -72,6 +72,9 @@ uint32_t calculateEditSOA(uint32_t old_serial, const string& kind, const DNSName
   else if(!kind.empty()) {
     g_log<<Logger::Warning<<"SOA-EDIT type '"<<kind<<"' for zone "<<zonename<<" is unknown."<<endl;
   }
+  // Seen strictly, this is a broken config: we can only come here if
+  // both SOA-EDIT and default-soa-edit are set to "", but the latter
+  // should be set to "NONE" instead.
   return old_serial;
 }