Author: Massimo Zito <zmax.linkedin at gmail dot com>

squid_radius_auth failed to process more than 256 requests

The radius request-id field is a unsigned char, but the internal request_id
counter was a integer causing mismatch after 256 queries.

diff --git a/helpers/basic_auth/squid_radius_auth/Changelog b/helpers/basic_auth/squid_radius_auth/Changelog
index 05d5cb041c691fb572fcc16b727978c7934d31ef..7560d92a8aa7cc3efbb697e467820019706aa1a6 100644 (file)
--- a/helpers/basic_auth/squid_radius_auth/Changelog
+++ b/helpers/basic_auth/squid_radius_auth/Changelog
@@ -1,3 +1,6 @@
+1.10: - Fix processing of more than 256 queries
+      - Send a dummy NAS-Port-Type attribute
+      - Documentation cleanup
 1.09: - RADIUS protocol fixes by Henrik Nordstrom <hno@squid-cache.org>
       - Corrected how retransmits & timeouts is handled
       - The shared secret now verified properly

diff --git a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
index 2b12f18fdb3bdf8e142977a9fbac446b385fb220..960cf65ed352ef8f2708e3be1e820453b6ec9e4a 100644 (file)
--- a/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
+++ b/helpers/basic_auth/squid_radius_auth/squid_rad_auth.c
@@ -105,7 +105,7 @@ static int i_recv_buffer[2048];
 static char *send_buffer = (char *) i_send_buffer;
 static char *recv_buffer = (char *) i_recv_buffer;
 static int sockfd;
-static int request_id;
+static u_char request_id;
 static char vector[AUTH_VECTOR_LEN];
 static char secretkey[MAXPASS + 1] = "";
 static char server[MAXLINE] = "";