]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mfd: adp5585: Drop useless return statement
authorNuno Sá <nuno.sa@analog.com>
Thu, 17 Jul 2025 14:51:34 +0000 (15:51 +0100)
committerLee Jones <lee@kernel.org>
Wed, 1 Oct 2025 09:28:03 +0000 (10:28 +0100)
In adp5585_reset_ev_parse(), when parsing the
adi,reset-pulse-width-us property, we were returning in case it was
found and valid. No point in doing that as we'll be returning anyways
after the exiting the property scope. And it could actually lead to bugs
if new properties happen to added after this one.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/linux-gpio/c85604d9e077511b8aa6ee0786579594cc0103d4.camel@gmail.com/T/#ma25557bd06ccd2531dc9c85ba6be74af781b81aa
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20250717-adp5585-drop-ret-v1-1-2ae65bd780aa@analog.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/adp5585.c

index 58f7cebe2ea4f2c68f64370449f5fbce8a2f14ed..46b3ce3d7bae8981824a957f6b4ee471d803c981 100644 (file)
@@ -432,7 +432,6 @@ static int adp5585_reset_ev_parse(struct adp5585_dev *adp5585)
                                             "Invalid value(%u) for adi,reset-pulse-width-us\n",
                                             prop_val);
                }
-               return ret;
        }
 
        return 0;