]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
ndisc: Also set link hoplimit
authorSusant Sahani <ssahani@gmail.com>
Fri, 8 Sep 2023 09:00:38 +0000 (14:30 +0530)
committerDaan De Meyer <daan.j.demeyer@gmail.com>
Wed, 27 Sep 2023 09:05:15 +0000 (11:05 +0200)
The per route hop limit does not place the hop limit in the IPv6 header.
https://github.com/systemd/systemd/issues/28437#issuecomment-1711055181

src/network/networkd-ndisc.c
src/network/networkd-sysctl.c
src/network/networkd-sysctl.h

index 08af9c73b9935321ace3af665ffc812683712458..f4f662cf965e490485cdc9b6921821557d8eba60 100644 (file)
@@ -199,7 +199,12 @@ static int ndisc_request_route(Route *in, Link *link, sd_ndisc_router *rt) {
                 r = sd_ndisc_router_get_hop_limit(rt, &hop_limit);
                 if (r < 0 && r != -ENODATA)
                         return log_link_warning_errno(link, r, "Failed to get default router hop limit from RA: %m");
-        }
+
+                link->network->ipv6_hop_limit = hop_limit;
+                r = link_set_ipv6_hop_limit(link);
+                if (r < 0)
+                        log_link_warning_errno(link, r, "Cannot set IPv6 hop limit for interface, ignoring: %m");
+       }
 
         route->source = NETWORK_CONFIG_SOURCE_NDISC;
         route->provider.in6 = router;
index 0b8169a0176626ae0322bf589dbea7c574391657..1a5dffe6f59591cd8ca6b5cadc5d0f6e93992ab9 100644 (file)
@@ -165,7 +165,7 @@ static int link_set_ipv6_dad_transmits(Link *link) {
         return sysctl_write_ip_property_int(AF_INET6, link->ifname, "dad_transmits", link->network->ipv6_dad_transmits);
 }
 
-static int link_set_ipv6_hop_limit(Link *link) {
+int link_set_ipv6_hop_limit(Link *link) {
         assert(link);
 
         /* Make this a NOP if IPv6 is not available */
index 064438462c014276faf0aa31a225d88903edca2d..99243f7a25d60d8fce4838f50312a0a16e0e3db7 100644 (file)
@@ -28,6 +28,7 @@ typedef enum IPReversePathFilter {
 
 int link_set_sysctl(Link *link);
 int link_set_ipv6_mtu(Link *link);
+int link_set_ipv6_hop_limit(Link *link);
 
 const char* ipv6_privacy_extensions_to_string(IPv6PrivacyExtensions i) _const_;
 IPv6PrivacyExtensions ipv6_privacy_extensions_from_string(const char *s) _pure_;