]> git.ipfire.org Git - thirdparty/freeradius-server.git/commitdiff
Pacify Coverity (CID #1520878)
authorNick Porter <nick@portercomputing.co.uk>
Wed, 3 Sep 2025 10:50:17 +0000 (11:50 +0100)
committerNick Porter <nick@portercomputing.co.uk>
Wed, 3 Sep 2025 10:50:17 +0000 (11:50 +0100)
Coverity doesn't see that fd < 0 means the lock was released

src/modules/rlm_linelog/rlm_linelog.c

index 396b5abc6e6e1c3a860616cf2096f72205b7b15c..bb8812de6a08b21c3f36340f06243f0e984b919d 100644 (file)
@@ -408,6 +408,8 @@ static int linelog_write(rlm_linelog_t const *inst, linelog_call_env_t const *ca
                fd = exfile_open(inst->file.ef, path, inst->file.permissions, &offset);
                if (fd < 0) {
                        RERROR("Failed to open %pV: %s", call_env->filename, fr_syserror(errno));
+
+                       /* coverity[missing_unlock] */
                        return -1;
                }