]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: phy: realtek: use string choices helpers
authorHeiner Kallweit <hkallweit1@gmail.com>
Mon, 3 Feb 2025 20:41:36 +0000 (21:41 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Feb 2025 10:08:21 +0000 (10:08 +0000)
Use string choices helpers to simplify the code.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202501190707.qQS8PGHW-lkp@intel.com/
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/realtek/realtek_main.c

index 572a933636b010a98fa45797da37319711c086a6..210fefac44d47323c54692edb66cea7425be9045 100644 (file)
@@ -13,6 +13,7 @@
 #include <linux/module.h>
 #include <linux/delay.h>
 #include <linux/clk.h>
+#include <linux/string_choices.h>
 
 #include "realtek.h"
 
@@ -422,11 +423,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
        } else if (ret) {
                dev_dbg(dev,
                        "%s 2ns TX delay (and changing the value from pin-strapping RXD1 or the bootloader)\n",
-                       val_txdly ? "Enabling" : "Disabling");
+                       str_enable_disable(val_txdly));
        } else {
                dev_dbg(dev,
                        "2ns TX delay was already %s (by pin-strapping RXD1 or bootloader configuration)\n",
-                       val_txdly ? "enabled" : "disabled");
+                       str_enabled_disabled(val_txdly));
        }
 
        ret = phy_modify_paged_changed(phydev, 0xd08, 0x15, RTL8211F_RX_DELAY,
@@ -437,11 +438,11 @@ static int rtl8211f_config_init(struct phy_device *phydev)
        } else if (ret) {
                dev_dbg(dev,
                        "%s 2ns RX delay (and changing the value from pin-strapping RXD0 or the bootloader)\n",
-                       val_rxdly ? "Enabling" : "Disabling");
+                       str_enable_disable(val_rxdly));
        } else {
                dev_dbg(dev,
                        "2ns RX delay was already %s (by pin-strapping RXD0 or bootloader configuration)\n",
-                       val_rxdly ? "enabled" : "disabled");
+                       str_enabled_disabled(val_rxdly));
        }
 
        if (priv->has_phycr2) {