]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: Drop reconnectBlockjobs from _qemuDomainObjPrivate struct
authorMichal Privoznik <mprivozn@redhat.com>
Wed, 15 Oct 2025 08:49:20 +0000 (10:49 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 15 Oct 2025 10:27:50 +0000 (12:27 +0200)
The 'reconnectBlockjobs' member of the _qemuDomainObjPrivate
struct is basically unused after v8.7.0-rc1~110. It's not even
formatted into the status XML, just parsed. This makes needless
noise.  Just drop the member.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/qemu/qemu_domain.c
src/qemu/qemu_domain.h

index 60a4bcc64c7189001e0765a9d52f01572f32712b..375e0e441a160663d663d58837b7b19cdc859ad8 100644 (file)
@@ -1907,7 +1907,6 @@ qemuDomainObjPrivateDataClear(qemuDomainObjPrivate *priv)
 
     priv->rememberOwner = false;
 
-    priv->reconnectBlockjobs = VIR_TRISTATE_BOOL_ABSENT;
     priv->allowReboot = VIR_TRISTATE_BOOL_ABSENT;
 
     g_clear_pointer(&priv->migrationCaps, virBitmapFree);
@@ -3211,14 +3210,8 @@ qemuDomainObjPrivateXMLParseBlockjobs(virDomainObj *vm,
 {
     g_autofree xmlNodePtr *nodes = NULL;
     ssize_t nnodes = 0;
-    g_autofree char *active = NULL;
-    int tmp;
     size_t i;
 
-    if ((active = virXPathString("string(./blockjobs/@active)", ctxt)) &&
-        (tmp = virTristateBoolTypeFromString(active)) > 0)
-        priv->reconnectBlockjobs = tmp;
-
     if ((nnodes = virXPathNodeSet("./blockjobs/blockjob", ctxt, &nodes)) < 0)
         return -1;
 
index 5ccd3b2dbbbce3007250d0f6974ea81b7e444389..f4945f598a819f500d4cc994e06830a69019ee4d 100644 (file)
@@ -195,9 +195,6 @@ struct _qemuDomainObjPrivate {
     /* If true virtlogd is used as stdio handler for character devices. */
     bool chardevStdioLogd;
 
-    /* Tracks blockjob state for vm. Valid only while reconnecting to qemu. */
-    virTristateBool reconnectBlockjobs;
-
     /* Migration capabilities. Rechecked on reconnect, not to be saved in
      * private XML. */
     virBitmap *migrationCaps;