]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nbd: call blk_mark_disk_dead in nbd_clear_sock_ioctl
authorChristoph Hellwig <hch@lst.de>
Fri, 11 Aug 2023 10:08:18 +0000 (12:08 +0200)
committerChristian Brauner <brauner@kernel.org>
Mon, 21 Aug 2023 12:35:30 +0000 (14:35 +0200)
nbd_clear_sock_ioctl kills the socket and with that the block
device.  Instead of just invalidating file system buffers,
mark the device as dead, which will also invalidate the buffers
as part of the proper shutdown sequence.  This also includes
invalidating partitions if there are any.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Message-Id: <20230811100828.1897174-8-hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
drivers/block/nbd.c

index 8576d696c7a22194ed25d0eb4fb2cfed381c6ce4..42e0159bb258fa817dd0baf29d40f52a06e8fbc1 100644 (file)
@@ -1434,12 +1434,10 @@ static int nbd_start_device_ioctl(struct nbd_device *nbd)
        return ret;
 }
 
-static void nbd_clear_sock_ioctl(struct nbd_device *nbd,
-                                struct block_device *bdev)
+static void nbd_clear_sock_ioctl(struct nbd_device *nbd)
 {
+       blk_mark_disk_dead(nbd->disk);
        nbd_clear_sock(nbd);
-       __invalidate_device(bdev, true);
-       nbd_bdev_reset(nbd);
        if (test_and_clear_bit(NBD_RT_HAS_CONFIG_REF,
                               &nbd->config->runtime_flags))
                nbd_config_put(nbd);
@@ -1465,7 +1463,7 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
        case NBD_DISCONNECT:
                return nbd_disconnect(nbd);
        case NBD_CLEAR_SOCK:
-               nbd_clear_sock_ioctl(nbd, bdev);
+               nbd_clear_sock_ioctl(nbd);
                return 0;
        case NBD_SET_SOCK:
                return nbd_add_socket(nbd, arg, false);