]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mfd: sec-common: Don't ignore errors from sec_irq_init()
authorAndré Draszik <andre.draszik@linaro.org>
Wed, 9 Apr 2025 20:37:37 +0000 (21:37 +0100)
committerLee Jones <lee@kernel.org>
Fri, 23 May 2025 07:48:41 +0000 (08:48 +0100)
sec_irq_init() can fail, we shouldn't continue and ignore the error in
that case, but actually error out.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250409-s2mpg10-v4-16-d66d5f39b6bf@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/sec-common.c

index f4c606c5ee5a809a106b13e947464f35a926b199..bb0eb3c2d9a260ddf2fb110cc255f08a0d25230d 100644 (file)
@@ -183,7 +183,9 @@ int sec_pmic_probe(struct device *dev, unsigned long device_type,
 
        sec_pmic->pdata = pdata;
 
-       sec_irq_init(sec_pmic);
+       ret = sec_irq_init(sec_pmic);
+       if (ret)
+               return ret;
 
        pm_runtime_set_active(sec_pmic->dev);