HID: pidff: Clamp effect playback LOOP_COUNT value

Ensures the loop count will never exceed the logical_maximum.

Fixes implementation errors happening when applications use the max
value of int32/DWORD as the effect iterations. This could be observed
when running software both native and in wine.

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index ffecc712be003580871265fb482c0d1ed5e412d7..74b033a4ac1b8ece665f325471cdc114eae67bb1 100644 (file)
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -690,7 +690,8 @@ static void pidff_playback_pid(struct pidff_device *pidff, int pid_id, int n)
        } else {
                pidff->effect_operation_status->value[0] =
                        pidff->operation_id[PID_EFFECT_START];
-               pidff->effect_operation[PID_LOOP_COUNT].value[0] = n;
+               pidff->effect_operation[PID_LOOP_COUNT].value[0] =
+                       pidff_clamp(n, pidff->effect_operation[PID_LOOP_COUNT].field);
        }
 
        hid_hw_request(pidff->hid, pidff->reports[PID_EFFECT_OPERATION],