]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
s390/ctcm: Use info level for handshake UC_RCRESET
authorAswin Karuvally <aswin@linux.ibm.com>
Mon, 3 Nov 2025 10:16:52 +0000 (11:16 +0100)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 6 Nov 2025 14:24:13 +0000 (15:24 +0100)
CTC adapter throws CTC_EVENT_UC_RCRESET (Unit check remote reset event)
during initial handshake, if the peer is not ready yet. This causes the
ctcm driver to re-attempt the handshake.

As it is normal for the event to occur during initialization, use info
instead of warn level in kernel log and NOTICE instead of ERROR level
in s390 debug feature. Also reword the log message for clarity.

Reviewed-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Aswin Karuvally <aswin@linux.ibm.com>
Link: https://patch.msgid.link/20251103101652.2349855-1-aswin@linux.ibm.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/s390/net/ctcm_fsms.c

index 9678c6a2cda727cb9a9a1a35efc6b94d476dfb84..1a48258b63b28f555ed1cb7337e1b232e96103fa 100644 (file)
@@ -882,6 +882,13 @@ static void ctcm_chx_rxiniterr(fsm_instance *fi, int event, void *arg)
                        fsm_newstate(fi, CTC_STATE_RXERR);
                        fsm_event(priv->fsm, DEV_EVENT_RXDOWN, dev);
                }
+       } else if (event == CTC_EVENT_UC_RCRESET) {
+               CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE,
+                              "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,
+                              ctc_ch_event_names[event], fsm_getstate_str(fi));
+
+               dev_info(&dev->dev,
+                        "Init handshake not received, peer not ready yet\n");
        } else {
                CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR,
                        "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,
@@ -967,6 +974,13 @@ static void ctcm_chx_txiniterr(fsm_instance *fi, int event, void *arg)
                        fsm_newstate(fi, CTC_STATE_TXERR);
                        fsm_event(priv->fsm, DEV_EVENT_TXDOWN, dev);
                }
+       } else if (event == CTC_EVENT_UC_RCRESET) {
+               CTCM_DBF_TEXT_(TRACE, CTC_DBF_NOTICE,
+                              "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,
+                              ctc_ch_event_names[event], fsm_getstate_str(fi));
+
+               dev_info(&dev->dev,
+                        "Init handshake not sent, peer not ready yet\n");
        } else {
                CTCM_DBF_TEXT_(ERROR, CTC_DBF_ERROR,
                        "%s(%s): %s in %s", CTCM_FUNTAIL, ch->id,