]> git.ipfire.org Git - thirdparty/git.git/commitdiff
merge-ort: handle D/F conflict where directory disappears due to merge
authorElijah Newren <newren@gmail.com>
Fri, 1 Jan 2021 02:34:39 +0000 (02:34 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 4 Jan 2021 18:40:45 +0000 (10:40 -0800)
When one side has a directory at a given path and the other side of
history has a file at the path, but the merge resolves the directory
away (e.g. because no path within that directory was modified and the
other side deleted it, or because renaming moved all the files
elsewhere), then we don't actually have a conflict anymore.  We just
need to clear away any information related to the relevant directory,
and then the subsequent process_entry() handling can handle the given
path.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-ort.c

index 414e7b7eeac087b7a9f435117f49d20cc1ae71a3..dd90987ae3d86141c69e41452004cc46f6713e5a 100644 (file)
@@ -976,7 +976,28 @@ static void process_entry(struct merge_options *opt,
                assert(ci->df_conflict);
        }
 
-       if (ci->df_conflict) {
+       if (ci->df_conflict && ci->merged.result.mode == 0) {
+               int i;
+
+               /*
+                * directory no longer in the way, but we do have a file we
+                * need to place here so we need to clean away the "directory
+                * merges to nothing" result.
+                */
+               ci->df_conflict = 0;
+               assert(ci->filemask != 0);
+               ci->merged.clean = 0;
+               ci->merged.is_null = 0;
+               /* and we want to zero out any directory-related entries */
+               ci->match_mask = (ci->match_mask & ~ci->dirmask);
+               ci->dirmask = 0;
+               for (i = MERGE_BASE; i <= MERGE_SIDE2; i++) {
+                       if (ci->filemask & (1 << i))
+                               continue;
+                       ci->stages[i].mode = 0;
+                       oidcpy(&ci->stages[i].oid, &null_oid);
+               }
+       } else if (ci->df_conflict && ci->merged.result.mode != 0) {
                die("Not yet implemented.");
        }