]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/psr: Perform scanline indication check for Panel Replay as well
authorJouni Högander <jouni.hogander@intel.com>
Wed, 19 Jun 2024 06:21:29 +0000 (09:21 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Tue, 25 Jun 2024 05:28:43 +0000 (08:28 +0300)
Scanline indication needs to be checked and configure for both PSR2 and
Panel Replay Selective Update. Move this check to
intel_sel_update_config_valid.

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240619062131.4021196-10-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index ba649762243537ff0c801540ecb38bc6cfe7d40f..ea5a254aa9425b62de92ad2aff0d2198d77f18a2 100644 (file)
@@ -1429,12 +1429,6 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
                return false;
        }
 
-       if (!_compute_psr2_sdp_prior_scanline_indication(intel_dp, crtc_state)) {
-               drm_dbg_kms(&dev_priv->drm,
-                           "PSR2 not enabled, PSR2 SDP indication do not fit in hblank\n");
-               return false;
-       }
-
        if (!alpm_config_valid(intel_dp, crtc_state, false))
                return false;
 
@@ -1476,6 +1470,12 @@ static bool intel_sel_update_config_valid(struct intel_dp *intel_dp,
        if (!crtc_state->has_panel_replay && !intel_psr2_config_valid(intel_dp, crtc_state))
                goto unsupported;
 
+       if (!_compute_psr2_sdp_prior_scanline_indication(intel_dp, crtc_state)) {
+               drm_dbg_kms(&dev_priv->drm,
+                           "Selective update not enabled, SDP indication do not fit in hblank\n");
+               goto unsupported;
+       }
+
        if (crtc_state->has_panel_replay && (DISPLAY_VER(dev_priv) < 14 ||
                                             !intel_dp->psr.sink_panel_replay_su_support))
                goto unsupported;