]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
power: supply: max17042_battery: Clear status bits in interrupt handler
authorSebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Tue, 14 Sep 2021 12:18:05 +0000 (14:18 +0200)
committerSebastian Reichel <sre@kernel.org>
Tue, 12 Oct 2021 15:59:05 +0000 (17:59 +0200)
The gauge requires us to clear the status bits manually for some alerts
to be properly dismissed. Previously the IRQ was configured to react only
on falling edge, which wasn't technically correct (the ALRT line is active
low), but it had a happy side-effect of preventing interrupt storms
on uncleared alerts from happening.

Fixes: 7fbf6b731bca ("power: supply: max17042: Do not enforce (incorrect) interrupt trigger type")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sebastian Krzyszkowiak <sebastian.krzyszkowiak@puri.sm>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/max17042_battery.c

index 32f33148048777b5c9657004b32148907e93a29c..2eb61856f3e44ec28adbf1377b6916a89883a054 100644 (file)
@@ -879,6 +879,10 @@ static irqreturn_t max17042_thread_handler(int id, void *dev)
                max17042_set_soc_threshold(chip, 1);
        }
 
+       /* we implicitly handle all alerts via power_supply_changed */
+       regmap_clear_bits(chip->regmap, MAX17042_STATUS,
+                         0xFFFF & ~(STATUS_POR_BIT | STATUS_BST_BIT));
+
        power_supply_changed(chip->battery);
        return IRQ_HANDLED;
 }