]> git.ipfire.org Git - thirdparty/git.git/commitdiff
apply: mark unused parameters in handlers
authorJeff King <peff@peff.net>
Tue, 18 Oct 2022 01:08:48 +0000 (21:08 -0400)
committerJunio C Hamano <gitster@pobox.com>
Tue, 18 Oct 2022 04:24:04 +0000 (21:24 -0700)
In parse_git_diff_header(), we have a table-driven parser that maps
strings to handler functions. Not all handlers need all of the
parameters; let's mark the unused ones to appease -Wunused-parameter.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
apply.c

diff --git a/apply.c b/apply.c
index 2b7cd930efa3bd31fec9ac72b94bac31272c4c09..fa9a02771cea6be7d93c14e707efae101bab2c62 100644 (file)
--- a/apply.c
+++ b/apply.c
@@ -892,9 +892,9 @@ static int parse_traditional_patch(struct apply_state *state,
        return 0;
 }
 
-static int gitdiff_hdrend(struct gitdiff_data *state,
-                         const char *line,
-                         struct patch *patch)
+static int gitdiff_hdrend(struct gitdiff_data *state UNUSED,
+                         const char *line UNUSED,
+                         struct patch *patch UNUSED)
 {
        return 1;
 }
@@ -1044,7 +1044,7 @@ static int gitdiff_renamedst(struct gitdiff_data *state,
        return 0;
 }
 
-static int gitdiff_similarity(struct gitdiff_data *state,
+static int gitdiff_similarity(struct gitdiff_data *state UNUSED,
                              const char *line,
                              struct patch *patch)
 {
@@ -1054,7 +1054,7 @@ static int gitdiff_similarity(struct gitdiff_data *state,
        return 0;
 }
 
-static int gitdiff_dissimilarity(struct gitdiff_data *state,
+static int gitdiff_dissimilarity(struct gitdiff_data *state UNUSED,
                                 const char *line,
                                 struct patch *patch)
 {
@@ -1104,9 +1104,9 @@ static int gitdiff_index(struct gitdiff_data *state,
  * This is normal for a diff that doesn't change anything: we'll fall through
  * into the next diff. Tell the parser to break out.
  */
-static int gitdiff_unrecognized(struct gitdiff_data *state,
-                               const char *line,
-                               struct patch *patch)
+static int gitdiff_unrecognized(struct gitdiff_data *state UNUSED,
+                               const char *line UNUSED,
+                               struct patch *patch UNUSED)
 {
        return 1;
 }