]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dma-buf: Fix __dma_buf_debugfs_list_del argument for !CONFIG_DEBUG_FS
authorT.J. Mercier <tjmercier@google.com>
Sun, 17 Nov 2024 17:03:25 +0000 (17:03 +0000)
committerSumit Semwal <sumit.semwal@linaro.org>
Thu, 12 Dec 2024 13:23:45 +0000 (18:53 +0530)
The arguments for __dma_buf_debugfs_list_del do not match for both the
CONFIG_DEBUG_FS case and the !CONFIG_DEBUG_FS case. The !CONFIG_DEBUG_FS
case should take a struct dma_buf *, but it's currently struct file *.
This can lead to the build error:

error: passing argument 1 of ‘__dma_buf_debugfs_list_del’ from
incompatible pointer type [-Werror=incompatible-pointer-types]

dma-buf.c:63:53: note: expected ‘struct file *’ but argument is of
type ‘struct dma_buf *’
   63 | static void __dma_buf_debugfs_list_del(struct file *file)

Fixes: bfc7bc539392 ("dma-buf: Do not build debugfs related code when !CONFIG_DEBUG_FS")
Signed-off-by: T.J. Mercier <tjmercier@google.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@igalia.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241117170326.1971113-1-tjmercier@google.com
drivers/dma-buf/dma-buf.c

index 5ad0e9e2e1b93b4095b48ce2c7dd37f8c4701666..84bc32134862245796c5c9cdd668a1dd5672c3ac 100644 (file)
@@ -60,7 +60,7 @@ static void __dma_buf_debugfs_list_add(struct dma_buf *dmabuf)
 {
 }
 
-static void __dma_buf_debugfs_list_del(struct file *file)
+static void __dma_buf_debugfs_list_del(struct dma_buf *dmabuf)
 {
 }
 #endif