]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: twl4030: Remove error print for devm_add_action_or_reset()
authorWaqar Hameed <waqar.hameed@axis.com>
Tue, 5 Aug 2025 09:33:33 +0000 (11:33 +0200)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Mon, 11 Aug 2025 09:09:23 +0000 (11:09 +0200)
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://lore.kernel.org/r/pndjz3im7te.a.out@axis.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-twl4030.c

index a33dc7c7e7a08d51d3f27d43d3becb206d7451a3..a851702befdea7a5d6efa5e24df06c5e8094585a 100644 (file)
@@ -597,9 +597,7 @@ no_irqs:
 
                ret = devm_add_action_or_reset(&pdev->dev, gpio_twl4030_power_off_action, d);
                if (ret)
-                       return dev_err_probe(&pdev->dev, ret,
-                                            "failed to install power off handler\n");
-
+                       return ret;
        }
 
        return 0;