Inline function tls_get_peer_info

All other places in our code also directly access peer_info and this
function does not contribute to code clarity.

Signed-off-by: Arne Schwabe <arne@rfc2549.org>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20201023113431.26691-1-arne@rfc2549.org>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg21217.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>

diff --git a/src/openvpn/multi.c b/src/openvpn/multi.c
index a5862020b81605416524b1beb925d2692c5c3eec..009b46fa170d18f234a3170436fd74526038f8ce 100644 (file)
--- a/src/openvpn/multi.c
+++ b/src/openvpn/multi.c
@@ -3993,7 +3993,7 @@ management_get_peer_info(void *arg, const unsigned long cid)
 
     if (mi)
     {
-        ret = tls_get_peer_info(mi->context.c2.tls_multi);
+        ret = mi->context.c2.tls_multi->peer_info;
     }
 
     return ret;

diff --git a/src/openvpn/ssl.h b/src/openvpn/ssl.h
index f00f8abd53a3bb1bab946168288cd5e7ae3ec0a5..f3032dabe7b5b369d9a9ad4a06772b21eba29c23 100644 (file)
--- a/src/openvpn/ssl.h
+++ b/src/openvpn/ssl.h
@@ -499,14 +499,6 @@ bool tls_session_update_crypto_params(struct tls_session *session,
                                       struct frame *frame,
                                       struct frame *frame_fragment);
 
-#ifdef MANAGEMENT_DEF_AUTH
-static inline char *
-tls_get_peer_info(const struct tls_multi *multi)
-{
-    return multi->peer_info;
-}
-#endif
-
 /*
  * inline functions
  */