]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virDomainDefParseXML: set the argument of virBitmapFree to NULL after calling virBitm...
authorLiuji (Jeremy) <jeremy.liu@huawei.com>
Wed, 11 Sep 2013 02:13:32 +0000 (22:13 -0400)
committerJán Tomko <jtomko@redhat.com>
Tue, 15 Oct 2013 14:27:42 +0000 (16:27 +0200)
After freeing the bitmap pointer, it must set the pointer to NULL.
This will avoid any other use of the freed memory of the bitmap pointer.

https://bugzilla.redhat.com/show_bug.cgi?id=1006710

Signed-off-by: Liuji (Jeremy) <jeremy.liu@huawei.com>
(cherry picked from commit ef5d51d491356f1f4287aa3a8b908b183b6dd9aa)

src/conf/domain_conf.c

index a16ebd14a703b7c49f2d2f0151eba354c9e98a3a..8824266dfa9024b9e2e5b4e6e8d39f9afabfa4f8 100644 (file)
@@ -10964,8 +10964,10 @@ virDomainDefParseXML(xmlDocPtr xml,
                     }
 
                     /* Ignore 'nodeset' if 'placement' is 'auto' finally */
-                    if (placement_mode == VIR_NUMA_TUNE_MEM_PLACEMENT_MODE_AUTO)
+                    if (placement_mode == VIR_NUMA_TUNE_MEM_PLACEMENT_MODE_AUTO) {
                         virBitmapFree(def->numatune.memory.nodemask);
+                        def->numatune.memory.nodemask = NULL;
+                    }
 
                     /* Copy 'placement' of <numatune> to <vcpu> if its 'placement'
                      * is not specified and 'placement' of <numatune> is specified.