Author: fancyrabbit <fancyrabbit@gmail.com>

Bug 2672: cacheMemMaxSize 32-bit overflow during snmpwalk

snint is 32-bits. Unwrapped the code casts int64 to int32 before
reducing the base unit size to MB.

diff --git a/src/snmp_agent.cc b/src/snmp_agent.cc
index eea994aed5ea2e4cb44df4e2e28e9c8324d4ab69..db394fdff316ce88666daaf640aa5faf9da35a52 100644 (file)
--- a/src/snmp_agent.cc
+++ b/src/snmp_agent.cc
@@ -124,13 +124,13 @@ snmp_confFn(variable_list * Var, snint * ErrP)
 
         case CONF_ST_MMAXSZ:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
-                                          (snint) Config.memMaxSize >> 20,
+                                          (snint) (Config.memMaxSize >> 20),
                                           ASN_INTEGER);
             break;
 
         case CONF_ST_SWMAXSZ:
             Answer = snmp_var_new_integer(Var->name, Var->name_length,
-                                          (snint) Store::Root().maxSize() >> 10,
+                                          (snint) (Store::Root().maxSize() >> 10),
                                           ASN_INTEGER);
             break;