]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
target/i386: fix avx2 instructions vzeroall and vpermdq
authorXinyu Li <lixinyu20s@ict.ac.cn>
Wed, 10 May 2023 14:52:22 +0000 (22:52 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 18 May 2023 17:46:55 +0000 (20:46 +0300)
vzeroall: xmm_regs should be used instead of xmm_t0
vpermdq: bit 3 and 7 of imm should be considered

Signed-off-by: Xinyu Li <lixinyu20s@ict.ac.cn>
Message-Id: <20230510145222.586487-1-lixinyu20s@ict.ac.cn>
Cc: qemu-stable@nongnu.org
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 056d649007bc9fdae9f1d576e77c1316e9a34468)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
target/i386/ops_sse.h
target/i386/tcg/emit.c.inc

index 0bd6bfad8a1700fc5d32cc78ccf8719e66c75a7d..fb63af7afa21588dea45f3c1fc7de53c6e97b6b0 100644 (file)
@@ -2497,6 +2497,14 @@ void helper_vpermdq_ymm(Reg *d, Reg *v, Reg *s, uint32_t order)
     d->Q(1) = r1;
     d->Q(2) = r2;
     d->Q(3) = r3;
+    if (order & 0x8) {
+        d->Q(0) = 0;
+        d->Q(1) = 0;
+    }
+    if (order & 0x80) {
+        d->Q(2) = 0;
+        d->Q(3) = 0;
+    }
 }
 
 void helper_vpermq_ymm(Reg *d, Reg *s, uint32_t order)
index 95fb4f52fabed48b2790e53dc7323a2f3f61f425..4fe8dec4274643efab58a58bdd52a78bb6f6f58f 100644 (file)
@@ -2285,7 +2285,7 @@ static void gen_VZEROALL(DisasContext *s, CPUX86State *env, X86DecodedInsn *deco
 {
     TCGv_ptr ptr = tcg_temp_new_ptr();
 
-    tcg_gen_addi_ptr(ptr, cpu_env, offsetof(CPUX86State, xmm_t0));
+    tcg_gen_addi_ptr(ptr, cpu_env, offsetof(CPUX86State, xmm_regs));
     gen_helper_memset(ptr, ptr, tcg_constant_i32(0),
                       tcg_constant_ptr(CPU_NB_REGS * sizeof(ZMMReg)));
 }