]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath11k: fix refcount leak in ath11k_ahb_fw_resources_init()
authorWentao Liang <vulab@iscas.ac.cn>
Tue, 9 Jun 2026 09:25:28 +0000 (09:25 +0000)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Thu, 9 Jul 2026 14:44:42 +0000 (07:44 -0700)
of_get_child_by_name() returns a node pointer with refcount
incremented, but the error path when ath11k_ahb_setup_msa_resources()
fails does not release it.  Add the missing of_node_put() to avoid
leaking the reference.

Cc: stable@vger.kernel.org
Fixes: 095cb947490c ("wifi: ath11k: allow missing memory-regions")
Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
Reviewed-by: Rameshkumar Sundaram <rameshkumar.sundaram@oss.qualcomm.com>
Link: https://patch.msgid.link/20260609092528.220547-1-vulab@iscas.ac.cn
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath11k/ahb.c

index f566d699d074a88aec0757625bb7f1b3a6ca6739..1e1dea485760b326013c9ba638790ae12e032e13 100644 (file)
@@ -996,6 +996,7 @@ static int ath11k_ahb_fw_resources_init(struct ath11k_base *ab)
        ret = ath11k_ahb_setup_msa_resources(ab);
        if (ret) {
                ath11k_err(ab, "failed to setup msa resources\n");
+               of_node_put(node);
                return ret;
        }