]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfsprogs: disable xfs_check for CRC enabled filesystems
authorDave Chinner <dchinner@redhat.com>
Fri, 7 Jun 2013 00:25:49 +0000 (10:25 +1000)
committerBen Myers <bpm@sgi.com>
Tue, 6 Aug 2013 19:58:05 +0000 (14:58 -0500)
Until xfs_db has full metadata CRC support, xfs_check will not be
able to fully verify filesystems in this format. Don't even
bother trying right now, and to make it simple to test full xfsprogs
installs with xfstests, just silently succeed.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Ben Myers <bpm@sgi.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
db/check.c

index 5b7498fda245aeffaa3706c9160ab9eefd5e1c33..dadfa972714b84600fa7a740c74c29cd029b1b56 100644 (file)
@@ -788,6 +788,20 @@ blockget_f(
                dbprintf(_("already have block usage information\n"));
                return 0;
        }
+
+       /*
+        * XXX: check does not support CRC enabled filesystems. Return
+        * immediately, silently, with success but  without doing anything here
+        * initially so that xfstests can run without modification on metadata
+        * enabled filesystems.
+        *
+        * XXX: ultimately we need to dump an error message here that xfstests
+        * filters out, or we need to actually do the work to make check support
+        * crc enabled filesystems.
+        */
+       if (xfs_sb_version_hascrc(&mp->m_sb))
+               return 0;
+
        if (!init(argc, argv)) {
                if (serious_error)
                        exitcode = 3;