global: Log mailbox_list internal errors

diff --git a/src/doveadm/doveadm-mail-index.c b/src/doveadm/doveadm-mail-index.c
index 47cc7b1f08be1d2d74a0026381b6762ceae00530..3e475c68c703ebf0eaccf5483cad106d370afaf6 100644 (file)
--- a/src/doveadm/doveadm-mail-index.c
+++ b/src/doveadm/doveadm-mail-index.c
@@ -206,7 +206,7 @@ cmd_index_run(struct doveadm_mail_cmd_context *_ctx, struct mail_user *user)
        }
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("Listing mailboxes failed: %s",
-                       mailbox_list_get_last_error(user->namespaces->list, NULL));
+                       mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
                doveadm_mail_failed_error(_ctx, MAIL_ERROR_TEMP);
                ret = -1;
        }

diff --git a/src/doveadm/doveadm-mail-mailbox.c b/src/doveadm/doveadm-mail-mailbox.c
index c35e45dc33186c6c38892dbfbf1eb34a93ad90a7..1e96b7f7530af2087edd85280802f745dd596c71 100644 (file)
--- a/src/doveadm/doveadm-mail-mailbox.c
+++ b/src/doveadm/doveadm-mail-mailbox.c
@@ -741,7 +741,7 @@ cmd_mailbox_path_run(struct doveadm_mail_cmd_context *_ctx,
        if (ret < 0) {
                i_error("Failed to lookup mailbox %s path: %s",
                        ctx->mailbox,
-                       mailbox_list_get_last_error(ns->list, &mail_error));
+                       mailbox_list_get_last_internal_error(ns->list, &mail_error));
                doveadm_mail_failed_error(_ctx, mail_error);
        } else if (ret > 0) {
                doveadm_print(path);

diff --git a/src/doveadm/doveadm-mail.c b/src/doveadm/doveadm-mail.c
index 50e6e57f9ac985b3ba03be7848be486366b2d65b..d26ed0b34cb5b864b9c50a2f088ff40596002c01 100644 (file)
--- a/src/doveadm/doveadm-mail.c
+++ b/src/doveadm/doveadm-mail.c
@@ -323,7 +323,7 @@ static int cmd_force_resync_run(struct doveadm_mail_cmd_context *ctx,
        }
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("Listing mailboxes failed: %s",
-                       mailbox_list_get_last_error(user->namespaces->list, NULL));
+                       mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
                doveadm_mail_failed_list(ctx, user->namespaces->list);
                ret = -1;
        }

diff --git a/src/doveadm/doveadm-mailbox-list-iter.c b/src/doveadm/doveadm-mailbox-list-iter.c
index 0ddaa87b02d1913505f3cd5b505b22e84ad7597c..d6a99c0f5c6a96ed000110507ac4734bbdd4addf 100644 (file)
--- a/src/doveadm/doveadm-mailbox-list-iter.c
+++ b/src/doveadm/doveadm-mailbox-list-iter.c
@@ -152,7 +152,7 @@ int doveadm_mailbox_list_iter_deinit(struct doveadm_mailbox_list_iter **_iter)
                ret = 0;
        else if ((ret = mailbox_list_iter_deinit(&iter->iter)) < 0) {
                i_error("Listing mailboxes failed: %s",
-                       mailbox_list_get_last_error(iter->user->namespaces->list, &error));
+                       mailbox_list_get_last_internal_error(iter->user->namespaces->list, &error));
                doveadm_mail_failed_error(iter->ctx, error);
        }
        array_free(&iter->patterns);

diff --git a/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c b/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
index bcdad767830c63ea8fd87b02624539fe99b16a33..4ad00fa9130d950d50672794dfe2b641cafe74d9 100644 (file)
--- a/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
+++ b/src/doveadm/dsync/dsync-brain-mailbox-tree-sync.c
@@ -148,7 +148,7 @@ int dsync_brain_mailbox_tree_sync_change(struct dsync_brain *brain,
                if (mailbox_list_delete_dir(change->ns->list, storage_name) == 0)
                        return 0;
 
-               errstr = mailbox_list_get_last_error(change->ns->list, &error);
+               errstr = mailbox_list_get_last_internal_error(change->ns->list, &error);
                if (error == MAIL_ERROR_NOTFOUND ||
                    error == MAIL_ERROR_EXISTS) {
                        dsync_brain_set_changes_during_sync(brain, t_strdup_printf(

diff --git a/src/doveadm/dsync/dsync-mailbox-tree-fill.c b/src/doveadm/dsync/dsync-mailbox-tree-fill.c
index f290f9fd49b0e35f1bf1e28f360694f18ae85906..086b7bbabcca52fa146a634038965bdf09f10e1c 100644 (file)
--- a/src/doveadm/dsync/dsync-mailbox-tree-fill.c
+++ b/src/doveadm/dsync/dsync-mailbox-tree-fill.c
@@ -361,7 +361,7 @@ int dsync_mailbox_tree_fill(struct dsync_mailbox_tree *tree,
        } T_END;
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("Mailbox listing for namespace '%s' failed: %s",
-                       ns->prefix, mailbox_list_get_last_error(ns->list, error_r));
+                       ns->prefix, mailbox_list_get_last_internal_error(ns->list, error_r));
                ret = -1;
        }
 
@@ -377,7 +377,7 @@ int dsync_mailbox_tree_fill(struct dsync_mailbox_tree *tree,
        }
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("Mailbox listing for namespace '%s' failed: %s",
-                       ns->prefix, mailbox_list_get_last_error(ns->list, error_r));
+                       ns->prefix, mailbox_list_get_last_internal_error(ns->list, error_r));
                ret = -1;
        }
        if (ret < 0)

diff --git a/src/imap/main.c b/src/imap/main.c
index fd9fd1950f677dcd7b446d6ffd2595f2b4abff2f..5c85394eac7838d794693fac23b3f56c50a81d60 100644 (file)
--- a/src/imap/main.c
+++ b/src/imap/main.c
@@ -240,7 +240,7 @@ int client_create_from_input(const struct mail_storage_service_input *input,
           imapc. */
        ns = mail_namespace_find_inbox(mail_user->namespaces);
        (void)mailbox_list_get_hierarchy_sep(ns->list);
-       errstr = mailbox_list_get_last_error(ns->list, &mail_error);
+       errstr = mailbox_list_get_last_internal_error(ns->list, &mail_error);
        if (mail_error != MAIL_ERROR_NONE) {
                *error_r = t_strdup(errstr);
                mail_user_unref(&mail_user);

diff --git a/src/lib-imap-urlauth/imap-urlauth-backend.c b/src/lib-imap-urlauth/imap-urlauth-backend.c
index 36ad1c5f91822b06d1e20740a35401a738325ad1..69d771ddf2b48271e8a7c7c260a4a2eda8a8dbb8 100644 (file)
--- a/src/lib-imap-urlauth/imap-urlauth-backend.c
+++ b/src/lib-imap-urlauth/imap-urlauth-backend.c
@@ -138,7 +138,7 @@ int imap_urlauth_backend_reset_all_keys(struct mail_user *user)
        }
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("urlauth key reset: Couldn't iterate mailboxes: %s",
-                       mailbox_list_get_last_error(user->namespaces->list, NULL));
+                       mailbox_list_get_last_internal_error(user->namespaces->list, NULL));
                ret = -1;
        }
        return ret;

diff --git a/src/lib-storage/list/mailbox-list-index-backend.c b/src/lib-storage/list/mailbox-list-index-backend.c
index fa07462ebf702783ab5b937a8fd711d0a531abd6..a3e803aadbdd78bd948afc1931fa8332408b863b 100644 (file)
--- a/src/lib-storage/list/mailbox-list-index-backend.c
+++ b/src/lib-storage/list/mailbox-list-index-backend.c
@@ -54,7 +54,7 @@ static int index_list_init(struct mailbox_list *_list, const char **error_r)
        if (mailbox_list_get_root_path(_list, MAILBOX_LIST_PATH_TYPE_INDEX, &dir) &&
            mailbox_list_mkdir_root(_list, dir, MAILBOX_LIST_PATH_TYPE_INDEX) < 0) {
                *error_r = t_strdup_printf("Failed to create the index root directory: %s",
-                                          mailbox_list_get_last_error(_list, NULL));
+                                          mailbox_list_get_last_internal_error(_list, NULL));
                return -1;
        }
        return 0;

diff --git a/src/lib-storage/mail-autoexpunge.c b/src/lib-storage/mail-autoexpunge.c
index 26dc2c3c4d2fb1e8c2d805e958dd67d8883e73c6..b1f8333db920e916af426f8abfbfddfe1186d507 100644 (file)
--- a/src/lib-storage/mail-autoexpunge.c
+++ b/src/lib-storage/mail-autoexpunge.c
@@ -177,7 +177,7 @@ mailbox_autoexpunge_wildcards(struct mail_namespace *ns,
        } T_END;
        if (mailbox_list_iter_deinit(&iter) < 0) {
                i_error("Failed to iterate autoexpunge mailboxes '%s': %s",
-                       iter_name, mailbox_list_get_last_error(ns->list, NULL));
+                       iter_name, mailbox_list_get_last_internal_error(ns->list, NULL));
        }
 }
 

diff --git a/src/plugins/quota/quota-count.c b/src/plugins/quota/quota-count.c
index 5b7019fa030d4d7c7d3bb20af2e01d9c823cc49e..dd1f98206c86988a4ecd9620ba8e78f4a2cc10b9 100644 (file)
--- a/src/plugins/quota/quota-count.c
+++ b/src/plugins/quota/quota-count.c
@@ -94,7 +94,7 @@ quota_mailbox_iter_deinit(struct quota_mailbox_iter **_iter)
                if (mailbox_list_iter_deinit(&iter->iter) < 0) {
                        i_error("quota: Listing namespace '%s' failed: %s",
                                iter->ns->prefix,
-                               mailbox_list_get_last_error(iter->ns->list, NULL));
+                               mailbox_list_get_last_internal_error(iter->ns->list, NULL));
                        ret = -1;
                }
        }
@@ -130,7 +130,7 @@ quota_mailbox_iter_next(struct quota_mailbox_iter *iter)
        if (mailbox_list_iter_deinit(&iter->iter) < 0) {
                i_error("quota: Listing namespace '%s' failed: %s",
                        iter->ns->prefix,
-                       mailbox_list_get_last_error(iter->ns->list, NULL));
+                       mailbox_list_get_last_internal_error(iter->ns->list, NULL));
                iter->failed = TRUE;
        }
        if (iter->ns->prefix_len > 0 &&

diff --git a/src/plugins/virtual/virtual-config.c b/src/plugins/virtual/virtual-config.c
index 2d41f6931027a5247ecd3770b9d6806f0588ac0a..cd5e7a170dffb1dd706343ccd7e79b22933c69df 100644 (file)
--- a/src/plugins/virtual/virtual-config.c
+++ b/src/plugins/virtual/virtual-config.c
@@ -440,7 +440,7 @@ static int virtual_config_expand_wildcards(struct virtual_parse_context *ctx,
        for (i = 0; i < count; i++)
                mail_search_args_unref(&wboxes[i]->search_args);
        if (mailbox_list_iter_deinit(&iter) < 0) {
-               *error_r = mailbox_list_get_last_error(user->namespaces->list, NULL);
+               *error_r = mailbox_list_get_last_internal_error(user->namespaces->list, NULL);
                return -1;
        }
        return ret < 0 ? -1 : 0;

diff --git a/src/pop3/pop3-client.c b/src/pop3/pop3-client.c
index ce3a288bb93b515f6154eaf0315d75a30ed32eb4..27362a8b36056b0ed9632e53c5f9fbe62b02835d 100644 (file)
--- a/src/pop3/pop3-client.c
+++ b/src/pop3/pop3-client.c
@@ -353,7 +353,7 @@ static int pop3_lock_session(struct client *client)
        }
        if (mailbox_list_mkdir_root(client->inbox_ns->list, dir, type) < 0) {
                i_error("pop3_lock_session: Couldn't create root directory %s: %s",
-                       dir, mailbox_list_get_last_error(client->inbox_ns->list, NULL));
+                       dir, mailbox_list_get_last_internal_error(client->inbox_ns->list, NULL));
                return -1;
        }
        path = t_strdup_printf("%s/"POP3_LOCK_FNAME, dir);