]> git.ipfire.org Git - people/pmueller/ipfire-2.x.git/commitdiff
firewall.cgi: Remove faulty assignments for selected hash.
authorStefan Schantl <stefan.schantl@ipfire.org>
Sun, 11 Jul 2021 17:54:16 +0000 (19:54 +0200)
committerArne Fitzenreiter <arne_f@ipfire.org>
Thu, 2 Sep 2021 08:56:07 +0000 (08:56 +0000)
The removed assignments are wrong because both are trying to assign
something different to the same key and will overwrite each other.

Secondary the assignment to the hash is not needed at this place, so it
safely can be removed.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Arne Fitzenreiter <arne_f@ipfire.org>
html/cgi-bin/firewall.cgi

index 70dee8d3cca38add53dabf0e2aa2607b187bb63b..d3cddfa2394ab7b8bf0f34869bd9ef12e7fd0b24 100644 (file)
@@ -1022,8 +1022,6 @@ sub gen_dd_block
        $checked{'TIME_SUN'}{$fwdfwsettings{'TIME_SUN'}}                = 'CHECKED';
        $selected{'TIME_FROM'}{$fwdfwsettings{'TIME_FROM'}}             = 'selected';
        $selected{'TIME_TO'}{$fwdfwsettings{'TIME_TO'}}                 = 'selected';
-       $selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp1'}}} ='selected';
-       $selected{'ipfire'}{$fwdfwsettings{$fwdfwsettings{'grp2'}}} ='selected';
 print<<END;
                <table width='100%' border='0'>
                <tr><td width='50%' valign='top'>