drm/i915/vrr: Allow fixed_rr with pipe joiner

VRR with joiner is currently disabled as it still needs some work to
correctly sequence the primary and secondary transcoders. However, we can
still use VRR Timing generator in fixed refresh rate for joiner and since
it just need to program vrr timings once and does not involve changing
timings on the fly. We still need to skip the VRR and LRR for joiner.

To achieve this set vrr.in_range to 0 for joiner case, so that we do not
try VRR and LRR for the joiner case.

v2: Avoid checks for secondary pipes, where not required. (Ville)
v3: Remove a redundant check and reset vrr.in_range to false. (Ville)

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/20250324133248.4071909-13-ankit.k.nautiyal@intel.com

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index c57e0319d83c23304633679e7b284bf71485734c..dda42522f461124a16ba0aa13056f299e7f376e6 100644 (file)
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -355,19 +355,23 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
        if (!HAS_VRR(display))
                return;
 
-       /*
-        * FIXME all joined pipes share the same transcoder.
-        * Need to account for that during VRR toggle/push/etc.
-        */
-       if (crtc_state->joiner_pipes)
-               return;
-
        if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
                return;
 
        crtc_state->vrr.in_range =
                intel_vrr_is_in_range(connector, drm_mode_vrefresh(adjusted_mode));
 
+       /*
+        * Allow fixed refresh rate with VRR Timing Generator.
+        * For now set the vrr.in_range to 0, to allow fixed_rr but skip actual
+        * VRR and LRR.
+        * #TODO For actual VRR with joiner, we need to figure out how to
+        * correctly sequence transcoder level stuff vs. pipe level stuff
+        * in the commit.
+        */
+       if (crtc_state->joiner_pipes)
+               crtc_state->vrr.in_range = false;
+
        vmin = intel_vrr_compute_vmin(crtc_state);
 
        if (crtc_state->vrr.in_range) {