x86/irq/32: Use named operands in inline asm

Also use inout "+" constraint modifier where appropriate.

Signed-off-by: Uros Bizjak <ubizjak@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250303155446.112769-1-ubizjak@gmail.com

diff --git a/arch/x86/kernel/irq_32.c b/arch/x86/kernel/irq_32.c
index dc1049c01f9b9aa19c6f986e975d382502bce062..c4719c40252fc7c681bfc40773148f2e9c189d42 100644 (file)
--- a/arch/x86/kernel/irq_32.c
+++ b/arch/x86/kernel/irq_32.c
@@ -54,12 +54,11 @@ static inline void print_stack_overflow(void) { }
 
 static void call_on_stack(void *func, void *stack)
 {
-       asm volatile("xchgl     %%ebx,%%esp     \n"
+       asm volatile("xchgl %[sp], %%esp\n"
                     CALL_NOSPEC
-                    "movl      %%ebx,%%esp     \n"
-                    : "=b" (stack)
-                    : "0" (stack),
-                      [thunk_target] "D"(func)
+                    "movl %[sp], %%esp"
+                    : [sp] "+b" (stack)
+                    : [thunk_target] "D" (func)
                     : "memory", "cc", "edx", "ecx", "eax");
 }
 
@@ -71,7 +70,7 @@ static inline void *current_stack(void)
 static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
 {
        struct irq_stack *curstk, *irqstk;
-       u32 *isp, *prev_esp, arg1;
+       u32 *isp, *prev_esp;
 
        curstk = (struct irq_stack *) current_stack();
        irqstk = __this_cpu_read(pcpu_hot.hardirq_stack_ptr);
@@ -94,12 +93,11 @@ static inline int execute_on_irq_stack(int overflow, struct irq_desc *desc)
        if (unlikely(overflow))
                call_on_stack(print_stack_overflow, isp);
 
-       asm volatile("xchgl     %%ebx,%%esp     \n"
+       asm volatile("xchgl %[sp], %%esp\n"
                     CALL_NOSPEC
-                    "movl      %%ebx,%%esp     \n"
-                    : "=a" (arg1), "=b" (isp)
-                    :  "0" (desc),   "1" (isp),
-                       [thunk_target] "D" (desc->handle_irq)
+                    "movl %[sp], %%esp"
+                    : "+a" (desc), [sp] "+b" (isp)
+                    : [thunk_target] "D" (desc->handle_irq)
                     : "memory", "cc", "ecx");
        return 1;
 }