]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soundwire: intel: ignore software command retries
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 1 Sep 2020 15:05:48 +0000 (23:05 +0800)
committerVinod Koul <vkoul@kernel.org>
Thu, 3 Sep 2020 10:44:38 +0000 (16:14 +0530)
with multiple links synchronized in hardware, retrying commands in
software is not recommended.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20200901150556.19432-3-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/soundwire/intel.c

index aa8484366c9579e74cd0d20ec5f6b4a6d022acb7..94a659e65f8637b71138aa55a36bd8c609ddb9c2 100644 (file)
@@ -1355,6 +1355,11 @@ static int intel_master_probe(struct platform_device *pdev)
                dev_info(dev,
                         "SoundWire master %d is disabled, will be ignored\n",
                         bus->link_id);
+       /*
+        * Ignore BIOS err_threshold, it's a really bad idea when dealing
+        * with multiple hardware synchronized links
+        */
+       bus->prop.err_threshold = 0;
 
        return 0;
 }