]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/amdxdna: Check drmm_mutex_init() return value
authorLizhi Hou <lizhi.hou@amd.com>
Tue, 7 Jul 2026 17:23:07 +0000 (10:23 -0700)
committerLizhi Hou <lizhi.hou@amd.com>
Wed, 8 Jul 2026 03:49:10 +0000 (20:49 -0700)
drmm_mutex_init() may fail and return an error. Check the return value
and abort initialization if mutex creation fails.

Fixes: 8c9ff1b181ba ("accel/amdxdna: Add a new driver for AMD AI Engine")
Reviewed-by: Max Zhen <max.zhen@amd.com>
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
Link: https://patch.msgid.link/20260707172307.539676-1-lizhi.hou@amd.com
drivers/accel/amdxdna/amdxdna_pci_drv.c

index e94d8290a80738ed11a574d8ea46c7ecab576eab..86e9c230875a0055326009f66e3ab8045e5fc3ed 100644 (file)
@@ -373,7 +373,10 @@ static int amdxdna_probe(struct pci_dev *pdev, const struct pci_device_id *id)
        if (ret)
                return ret;
 
-       drmm_mutex_init(ddev, &xdna->dev_lock);
+       ret = drmm_mutex_init(ddev, &xdna->dev_lock);
+       if (ret)
+               return ret;
+
        init_rwsem(&xdna->notifier_lock);
        INIT_LIST_HEAD(&xdna->client_list);
        pci_set_drvdata(pdev, xdna);