]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
um: Always dump trace for specified task in show_stack
authorTiwei Bie <tiwei.btw@antgroup.com>
Wed, 6 Nov 2024 10:39:33 +0000 (18:39 +0800)
committerJohannes Berg <johannes.berg@intel.com>
Thu, 7 Nov 2024 17:05:22 +0000 (18:05 +0100)
Currently, show_stack() always dumps the trace of the current task.
However, it should dump the trace of the specified task if one is
provided. Otherwise, things like running "echo t > sysrq-trigger"
won't work as expected.

Fixes: 970e51feaddb ("um: Add support for CONFIG_STACKTRACE")
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
Link: https://patch.msgid.link/20241106103933.1132365-1-tiwei.btw@antgroup.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
arch/um/kernel/sysrq.c

index a3bdab0486173dcb7a7728713d7f8113f34513e8..13ee5666668dd450ed377289a3c222b566467c16 100644 (file)
@@ -46,5 +46,5 @@ void show_stack(struct task_struct *task, unsigned long *stack,
        }
 
        printk("%sCall Trace:\n", loglvl);
-       dump_trace(current, &stackops, (void *)loglvl);
+       dump_trace(task ?: current, &stackops, (void *)loglvl);
 }