]> git.ipfire.org Git - thirdparty/git.git/commitdiff
refs: remove old refs_warn_dangling_symref
authorPhil Hord <phil.hord@gmail.com>
Wed, 2 Jul 2025 01:12:14 +0000 (18:12 -0700)
committerJunio C Hamano <gitster@pobox.com>
Wed, 2 Jul 2025 01:42:25 +0000 (18:42 -0700)
The dangling warning function that takes a single ref to search for
is no longer used.  Remove it.

Signed-off-by: Phil Hord <phil.hord@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs.c
refs.h

diff --git a/refs.c b/refs.c
index def147b685203d389cec893b25cb08d3ad17a815..b0e67077a6c994bf2235b4acd9ba6fac44e190ec 100644 (file)
--- a/refs.c
+++ b/refs.c
@@ -438,7 +438,6 @@ static int for_each_filter_refs(const char *refname, const char *referent,
 struct warn_if_dangling_data {
        struct ref_store *refs;
        FILE *fp;
-       const char *refname;
        const struct string_list *refnames;
        const char *msg_fmt;
 };
@@ -455,9 +454,7 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
 
        resolves_to = refs_resolve_ref_unsafe(d->refs, refname, 0, NULL, NULL);
        if (!resolves_to
-           || (d->refname
-               ? strcmp(resolves_to, d->refname)
-               : !string_list_has_string(d->refnames, resolves_to))) {
+           || !string_list_has_string(d->refnames, resolves_to)) {
                return 0;
        }
 
@@ -466,18 +463,6 @@ static int warn_if_dangling_symref(const char *refname, const char *referent UNU
        return 0;
 }
 
-void refs_warn_dangling_symref(struct ref_store *refs, FILE *fp,
-                              const char *msg_fmt, const char *refname)
-{
-       struct warn_if_dangling_data data = {
-               .refs = refs,
-               .fp = fp,
-               .refname = refname,
-               .msg_fmt = msg_fmt,
-       };
-       refs_for_each_rawref(refs, warn_if_dangling_symref, &data);
-}
-
 void refs_warn_dangling_symrefs(struct ref_store *refs, FILE *fp,
                                const char *msg_fmt, const struct string_list *refnames)
 {
diff --git a/refs.h b/refs.h
index a0cdd99250e8286b55808b697b0a94afac5d8319..60642bc24ac90a4248658c5881ff68b84366357c 100644 (file)
--- a/refs.h
+++ b/refs.h
@@ -435,8 +435,6 @@ static inline const char *has_glob_specials(const char *pattern)
        return strpbrk(pattern, "?*[");
 }
 
-void refs_warn_dangling_symref(struct ref_store *refs, FILE *fp,
-                              const char *msg_fmt, const char *refname);
 void refs_warn_dangling_symrefs(struct ref_store *refs, FILE *fp,
                                const char *msg_fmt, const struct string_list *refnames);