]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: rockchip: Fix the headphone detection on the orangepi 5
authorJimmy Hon <honyuenkwun@gmail.com>
Thu, 4 Sep 2025 03:01:50 +0000 (03:01 +0000)
committerHeiko Stuebner <heiko@sntech.de>
Sun, 7 Sep 2025 17:20:40 +0000 (19:20 +0200)
The logic of the headphone detect pin seems to be inverted, with this
change headphones actually output sound when plugged in.

Does not need workaround of using pin-switches to enable output.

Verified by checking /sys/kernel/debug/gpio.

Fixes: ae46756faff8 ("arm64: dts: rockchip: analog audio on Orange Pi 5")
Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
Link: https://lore.kernel.org/r/20250904030150.986042-1-honyuenkwun@gmail.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi

index 4fedc50cce8c8601fedbe0f7fff719fade27a145..11940c77f2bd018a39ffd4e558e2f3688245e1d4 100644 (file)
@@ -42,9 +42,8 @@
                simple-audio-card,bitclock-master = <&masterdai>;
                simple-audio-card,format = "i2s";
                simple-audio-card,frame-master = <&masterdai>;
-               simple-audio-card,hp-det-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_LOW>;
+               simple-audio-card,hp-det-gpios = <&gpio1 RK_PD5 GPIO_ACTIVE_HIGH>;
                simple-audio-card,mclk-fs = <256>;
-               simple-audio-card,pin-switches = "Headphones";
                simple-audio-card,routing =
                        "Headphones", "LOUT1",
                        "Headphones", "ROUT1",