Fix a resource leak on hostapd maclist parsing error path

The open file needs to be closed in error case. The conversion to using
a new helper function (hostapd_add_acl_maclist) somehow managed to
remove the neede fclose(f) call. Bring it back to fix this.

Fixes: 3988046de538 ("hostapd: Dynamic MAC ACL management over control interface")
Signed-off-by: Jouni Malinen <jouni@codeaurora.org>

diff --git a/hostapd/config_file.c b/hostapd/config_file.c
index 8075b6dac9ff27bc726887d1d6618797ec2e495c..6ba5aae1b39e05a8223228096c411b346bad9284 100644 (file)
--- a/hostapd/config_file.c
+++ b/hostapd/config_file.c
@@ -217,8 +217,10 @@ static int hostapd_config_read_maclist(const char *fname,
                if (*pos != '\0')
                        vlan_id = atoi(pos);
 
-               if (hostapd_add_acl_maclist(acl, num, vlan_id, addr) < 0)
+               if (hostapd_add_acl_maclist(acl, num, vlan_id, addr) < 0) {
+                       fclose(f);
                        return -1;
+               }
        }
 
        fclose(f);