]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.14-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Nov 2019 04:59:47 +0000 (05:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Nov 2019 04:59:47 +0000 (05:59 +0100)
added patches:
memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch

queue-4.14/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch [new file with mode: 0644]
queue-4.14/series

diff --git a/queue-4.14/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch b/queue-4.14/memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch
new file mode 100644 (file)
index 0000000..83adb21
--- /dev/null
@@ -0,0 +1,39 @@
+From zhongjiang@huawei.com  Tue Nov 19 05:55:06 2019
+From: zhong jiang <zhongjiang@huawei.com>
+Date: Mon, 18 Nov 2019 11:26:07 +0800
+Subject: memfd: Use radix_tree_deref_slot_protected to avoid the warning.
+To: <sashal@kernel.org>, <gregkh@linuxfoundation.org>, <stable@vger.kernel.org>, <willy@infradead.org>
+Cc: <linux-mm@kvack.org>, <yangyingliang@huawei.com>
+Message-ID: <20191118032610.182862-1-zhongjiang@huawei.com>
+
+From: zhong jiang <zhongjiang@huawei.com>
+
+The commit 391d4ee568b5 ("memfd: Fix locking when tagging pins")
+introduces the following warning messages.
+
+*WARNING: suspicious RCU usage in memfd_wait_for_pins*
+
+It is because we still use radix_tree_deref_slot without read_rcu_lock.
+We should use radix_tree_deref_slot_protected instead in the case.
+
+Cc: stable@vger.kernel.org
+Fixes: 391d4ee568b5 ("memfd: Fix locking when tagging pins")
+Signed-off-by: zhong jiang <zhongjiang@huawei.com>
+Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ mm/shmem.c |    2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+--- a/mm/shmem.c
++++ b/mm/shmem.c
+@@ -2664,7 +2664,7 @@ static void shmem_tag_pins(struct addres
+       spin_lock_irq(&mapping->tree_lock);
+       radix_tree_for_each_slot(slot, &mapping->page_tree, &iter, start) {
+-              page = radix_tree_deref_slot(slot);
++              page = radix_tree_deref_slot_protected(slot, &mapping->tree_lock);
+               if (!page || radix_tree_exception(page)) {
+                       if (radix_tree_deref_retry(page)) {
+                               slot = radix_tree_iter_retry(&iter);
index 4b01f173d94455fc8c131100557cb09b9f79fcce..432c1579feebaf9d1fc075b0c4c75275b424b3d2 100644 (file)
@@ -237,3 +237,4 @@ usb-xhci-mtk-fix-isoc-error-when-interval-is-zero.patch
 fuse-use-read_once-on-congestion_threshold-and-max_b.patch
 ib-iser-fix-possible-null-deref-at-iser_inv_desc.patch
 net-phy-mdio-bcm-unimac-mark-pm-functions-as-__maybe.patch
+memfd-use-radix_tree_deref_slot_protected-to-avoid-the-warning.patch