]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
riscv: uaccess: fix __put_user_nocheck for unaligned accesses
authorAurelien Jarno <aurelien@aurel32.net>
Thu, 24 Jul 2025 22:08:52 +0000 (00:08 +0200)
committerPaul Walmsley <pjw@kernel.org>
Fri, 5 Sep 2025 21:30:48 +0000 (15:30 -0600)
The type of the value to write should be determined by the size of the
destination, not by the value itself, which may be a constant. This
aligns the behavior with x86_64, where __typeof__(*(__gu_ptr)) is used
to infer the correct type.

This fixes an issue in put_cmsg, which was only writing 4 out of 8
bytes to the cmsg_len field, causing the glibc tst-socket-timestamp test
to fail.

Fixes: ca1a66cdd685 ("riscv: uaccess: do not do misaligned accesses in get/put_user()")
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250724220853.1969954-1-aurelien@aurel32.net
Signed-off-by: Paul Walmsley <pjw@kernel.org>
arch/riscv/include/asm/uaccess.h

index b88a6218b7f243a42eff73f2f39ae6a9af26fedd..22e3f52a763d1c0350e8185225e4c99aac3fc549 100644 (file)
@@ -311,7 +311,7 @@ do {                                                                \
 do {                                                           \
        if (!IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS) &&      \
            !IS_ALIGNED((uintptr_t)__gu_ptr, sizeof(*__gu_ptr))) {      \
-               __inttype(x) ___val = (__inttype(x))x;                  \
+               __typeof__(*(__gu_ptr)) ___val = (x);           \
                if (__asm_copy_to_user_sum_enabled(__gu_ptr, &(___val), sizeof(*__gu_ptr))) \
                        goto label;                             \
                break;                                          \