]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: colibri-vf50-ts - make use of the helper function dev_err_probe()
authorCai Huoqing <caihuoqing@baidu.com>
Thu, 16 Sep 2021 15:31:48 +0000 (23:31 +0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 19 Aug 2024 17:22:56 +0000 (10:22 -0700)
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210916153148.14045-1-caihuoqing@baidu.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/colibri-vf50-ts.c

index aa829725ded7f5b8a2dc137d3416329803adf235..98d5b2ba63fb9993edd77a63b7c9875a33008d67 100644 (file)
@@ -239,14 +239,10 @@ static void vf50_ts_close(struct input_dev *dev_input)
 static int vf50_ts_get_gpiod(struct device *dev, struct gpio_desc **gpio_d,
                             const char *con_id, enum gpiod_flags flags)
 {
-       int error;
-
        *gpio_d = devm_gpiod_get(dev, con_id, flags);
-       if (IS_ERR(*gpio_d)) {
-               error = PTR_ERR(*gpio_d);
-               dev_err(dev, "Could not get gpio_%s %d\n", con_id, error);
-               return error;
-       }
+       if (IS_ERR(*gpio_d))
+               return dev_err_probe(dev, PTR_ERR(*gpio_d),
+                                    "Could not get gpio_%s\n", con_id);
 
        return 0;
 }