]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
mfd: mxs-lradc: Fix Wvoid-pointer-to-enum-cast warning (again)
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 6 Jun 2024 14:36:47 +0000 (16:36 +0200)
committerLee Jones <lee@kernel.org>
Thu, 4 Jul 2024 16:38:40 +0000 (17:38 +0100)
'type' is an enum, thus cast of pointer on 64-bit compile test with
clang and W=1 causes:

  mxs-lradc.c:140:15: error: cast to smaller integer type 'enum mxs_lradc_id' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast]

Year ago this was solved, although LKML discussion suggested warning is
not suitable for kernel.  Nothing changed in this regard for a year, so
assume the warning will stay and we want to have warnings-free builds.

Link: https://lore.kernel.org/all/20230814160457.GA2836@dev-arch.thelio-3990X/
Link: https://lore.kernel.org/all/20230810095849.123321-1-krzysztof.kozlowski@linaro.org/
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240606143648.152668-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/mxs-lradc.c

index 73893890b50a0febe2707db22c4bff309c461f0d..b2ebb54331216b98289f899cd68157afb2665a04 100644 (file)
@@ -137,7 +137,7 @@ static int mxs_lradc_probe(struct platform_device *pdev)
        if (!lradc)
                return -ENOMEM;
 
-       lradc->soc = (enum mxs_lradc_id)device_get_match_data(&pdev->dev);
+       lradc->soc = (kernel_ulong_t)device_get_match_data(&pdev->dev);
 
        lradc->clk = devm_clk_get(&pdev->dev, NULL);
        if (IS_ERR(lradc->clk)) {