]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
counter: microchip-tcb-capture: Allow shared IRQ for multi-channel TCBs
authorDharma Balasubiramani <dharma.b@microchip.com>
Mon, 6 Oct 2025 10:51:50 +0000 (16:21 +0530)
committerWilliam Breathitt Gray <wbg@kernel.org>
Mon, 13 Oct 2025 05:56:30 +0000 (14:56 +0900)
Mark the interrupt as IRQF_SHARED to permit multiple counter channels to
share the same TCB IRQ line.

Each Timer/Counter Block (TCB) instance shares a single IRQ line among its
three internal channels. When multiple counter channels (e.g., counter@0
and counter@1) within the same TCB are enabled, the second call to
devm_request_irq() fails because the IRQ line is already requested by the
first channel.

Cc: stable@vger.kernel.org
Fixes: e5d581396821 ("counter: microchip-tcb-capture: Add IRQ handling")
Signed-off-by: Dharma Balasubiramani <dharma.b@microchip.com>
Reviewed-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
Reviewed-by: Bence Csókás <bence98@sch.bme.hu>
Link: https://lore.kernel.org/r/20251006-microchip-tcb-v1-1-09c19181bb4a@microchip.com
Signed-off-by: William Breathitt Gray <wbg@kernel.org>
drivers/counter/microchip-tcb-capture.c

index 1a299d1f350b840dae1417571739ee07c6fb2659..19d457ae4c3bb373b6d323724b6b7613e51781aa 100644 (file)
@@ -451,7 +451,7 @@ static void mchp_tc_irq_remove(void *ptr)
 static int mchp_tc_irq_enable(struct counter_device *const counter, int irq)
 {
        struct mchp_tc_data *const priv = counter_priv(counter);
-       int ret = devm_request_irq(counter->parent, irq, mchp_tc_isr, 0,
+       int ret = devm_request_irq(counter->parent, irq, mchp_tc_isr, IRQF_SHARED,
                                   dev_name(counter->parent), counter);
 
        if (ret < 0)