libelf/libdwfl: Remove LIB_SYSTEM_H define in lib{elf,dwfl}_crc32.c

rationale: https://sourceware.org/bugzilla/show_bug.cgi?id=21001

If we don't remove this macro, when try #include <system.h> in
libdw/memory-access.h wont' take effect because
"#define LIB_SYSTEM_H	1"
The compile error:
./../libdw/memory-access.h:390:12: error: implicit declaration of
function ‘bswap_32’ [-Werror=implicit-function-declaration]

Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index faa97fca6e62236b241e7e613a58cdb07bda31eb..5254ac4553adfe461a541746b599736c38654e96 100644 (file)
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2022-10-21  Yonggang Luo  <luoyonggang@gmail.com>
+
+       * libdwfl_crc32.c: Remove LIB_SYSTEM_H define.
+
 2022-09-20  Yonggang Luo  <luoyonggang@gmail.com>
 
        * dwfl_segment_report_module.c: Use BYTE_ORDER, LITTLE_ENDIAN and

diff --git a/libdwfl/libdwfl_crc32.c b/libdwfl/libdwfl_crc32.c
index b89d0d36b8185d6cf7a30d13d173851b17f5268f..5bc7a4add14f4836b64be4f62ba10db7849eeda9 100644 (file)
--- a/libdwfl/libdwfl_crc32.c
+++ b/libdwfl/libdwfl_crc32.c
@@ -30,6 +30,5 @@
 #endif
 
 #define crc32 attribute_hidden __libdwfl_crc32
-#define LIB_SYSTEM_H   1
 #include <libdwflP.h>
 #include "../lib/crc32.c"

diff --git a/libelf/ChangeLog b/libelf/ChangeLog
index 86b12e815b40a246d0bdd2b440a522936bad9d12..aefb31b38c0309fa75cf9a04fb4e21327a590e8e 100644 (file)
--- a/libelf/ChangeLog
+++ b/libelf/ChangeLog
@@ -1,3 +1,7 @@
+2022-10-21  Yonggang Luo  <luoyonggang@gmail.com>
+
+       * libelf_crc32.c: Remove LIB_SYSTEM_H define.
+
 2022-09-20  Yonggang Luo  <luoyonggang@gmail.com>
 
        * elf32_checksum.c: Use BYTE_ORDER, LITTLE_ENDIAN and BIG_ENDIAN.

diff --git a/libelf/libelf_crc32.c b/libelf/libelf_crc32.c
index 1426faf1a30291b233cbe5e3e872483f5c55603f..f1cf4868599c688f0aa7aa488d121b0f27a3e698 100644 (file)
--- a/libelf/libelf_crc32.c
+++ b/libelf/libelf_crc32.c
@@ -30,6 +30,5 @@
 #endif
 
 #define crc32 attribute_hidden __libelf_crc32
-#define LIB_SYSTEM_H   1
 #include <libelf.h>
 #include "../lib/crc32.c"