]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
bnxt_en: Improve comment wording and error return code
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Sun, 15 Jun 2025 15:40:40 +0000 (08:40 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 17 Jun 2025 23:11:33 +0000 (16:11 -0700)
Improved wording and grammar in several comments for clarity.
  "the must belongs" -> "it must belong"
  "mininum" -> "minimum"
  "fileds" -> "fields"

Replaced return -1 with -EINVAL in hwrm_ring_alloc_send_msg()
to return a proper error code.

These changes enhance code readability and consistent error handling.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://patch.msgid.link/20250615154051.1365631-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt.c
drivers/net/ethernet/broadcom/bnxt/bnxt_sriov.c
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c

index 869580b6f70ddf10f0f9b92c69c435b00bcec895..00a60b2b90c44d78ee75dd84f19aa2077de05854 100644 (file)
@@ -1810,7 +1810,7 @@ static struct net_device *bnxt_get_pkt_dev(struct bnxt *bp, u16 cfa_code)
 {
        struct net_device *dev = bnxt_get_vf_rep(bp, cfa_code);
 
-       /* if vf-rep dev is NULL, the must belongs to the PF */
+       /* if vf-rep dev is NULL, it must belong to the PF */
        return dev ? dev : bp->dev;
 }
 
@@ -7116,7 +7116,7 @@ static int hwrm_ring_alloc_send_msg(struct bnxt *bp,
        default:
                netdev_err(bp->dev, "hwrm alloc invalid ring type %d\n",
                           ring_type);
-               return -1;
+               return -EINVAL;
        }
 
        resp = hwrm_req_hold(bp, req);
index 5ddddd89052ff3cfb44a1d943e5d4a9325ef9886..bc0d80356568767e6fd00918c07dc70278d7dfe8 100644 (file)
@@ -823,7 +823,7 @@ static int bnxt_sriov_enable(struct bnxt *bp, int *num_vfs)
        int tx_ok = 0, rx_ok = 0, rss_ok = 0;
        int avail_cp, avail_stat;
 
-       /* Check if we can enable requested num of vf's. At a mininum
+       /* Check if we can enable requested num of vf's. At a minimum
         * we require 1 RX 1 TX rings for each VF. In this minimum conf
         * features like TPA will not be available.
         */
index d2ca90407cce7603010a45e1da7aa435ea90bf79..0599d30162241f313e089bc6ba3353453527fd16 100644 (file)
@@ -1316,7 +1316,7 @@ static int bnxt_tc_get_decap_handle(struct bnxt *bp, struct bnxt_tc_flow *flow,
 
        /* Check if there's another flow using the same tunnel decap.
         * If not, add this tunnel to the table and resolve the other
-        * tunnel header fileds. Ignore src_port in the tunnel_key,
+        * tunnel header fields. Ignore src_port in the tunnel_key,
         * since it is not required for decap filters.
         */
        decap_key->tp_src = 0;
@@ -1410,7 +1410,7 @@ static int bnxt_tc_get_encap_handle(struct bnxt *bp, struct bnxt_tc_flow *flow,
 
        /* Check if there's another flow using the same tunnel encap.
         * If not, add this tunnel to the table and resolve the other
-        * tunnel header fileds
+        * tunnel header fields
         */
        encap_node = bnxt_tc_get_tunnel_node(bp, &tc_info->encap_table,
                                             &tc_info->encap_ht_params,