]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
parallels: Need to handle virJSONValueObjectGetString error
authorJohn Ferlan <jferlan@redhat.com>
Fri, 18 Jan 2013 14:30:40 +0000 (09:30 -0500)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 22 Jan 2013 13:34:12 +0000 (14:34 +0100)
src/parallels/parallels_driver.c

index ea193af72dddd50fef40841b15305c278fae8a0d..1b4724616700b38d02ea83254363c6c07758e798 100644 (file)
@@ -513,10 +513,9 @@ parallelsGetNetInfo(virDomainNetDefPtr net,
     }
 
     net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_UP;
-    if (virJSONValueObjectHasKey(value, "state")) {
-        tmp = virJSONValueObjectGetString(value, "state");
-        if STREQ(tmp, "disconnected")
-            net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
+    if ((tmp = virJSONValueObjectGetString(value, "state")) &&
+        STREQ(tmp, "disconnected")) {
+        net->linkstate = VIR_DOMAIN_NET_INTERFACE_LINK_STATE_DOWN;
     }
 
     return 0;